Tighten PHPStan ignore handling and replace broad suppressions with targeted fixes by Copilot · Pull Request #155 · voku/Arrayy

Copilot · 2026-04-13T05:26:33Z

Reproduce the current PHPUnit and PHPStan baselines before editing
Review PHPStan 2 inline ignore syntax and inventory current @phpstan-ignore-line / @phpstan-ignore-next-line usage
Replace the generic inline ignores in the relevant production and test files with identifier-specific @phpstan-ignore ... comments where the identifier is known and stable
Run targeted PHPStan and PHPUnit checks for the touched files, then re-check the repository baselines
Commit the migration and record any unchanged pre-existing PHPStan/PHPUnit failures

This change is

Agent-Logs-Url: https://github.com/voku/Arrayy/sessions/a2861208-06a3-4d4d-b396-8a01a9ea1c6c Co-authored-by: voku <264695+voku@users.noreply.github.com>

coveralls · 2026-04-13T05:28:23Z

coverage: 89.336% (-0.02%) from 89.36% — copilot/run-blind-spot-on-phpstan-errors into master

voku · 2026-04-13T05:32:16Z

/gemini review

gemini-code-assist

Code Review

This pull request improves PHPStan static analysis by enabling unmatched error reporting, adding generic type hints to iterator classes, and replacing call_user_func with direct method calls. Feedback suggests using the @phpstan-consistent-constructor annotation and the static::create() factory method to eliminate several newly added inline suppressions and improve code consistency.

gemini-code-assist · 2026-04-13T05:36:08Z

        bool $checkPropertiesInConstructor = true
    ) {
-        return new static(
+        return new static( // @phpstan-ignore new.static


Instead of multiple inline @phpstan-ignore new.static suppressions, consider adding the @phpstan-consistent-constructor annotation to the Arrayy class definition. This informs PHPStan that all subclasses are expected to maintain a compatible constructor signature, which is a cleaner way to resolve this warning globally for the entire class hierarchy.

gemini-code-assist · 2026-04-13T05:36:08Z

    {
        // init
-        $arrayy = new static();
+        $arrayy = new static(); // @phpstan-ignore new.static


You can avoid this inline suppression by using the existing factory method static::create(). This also ensures that any instantiation logic within create() is consistently applied.

$arrayy = static::create();

gemini-code-assist · 2026-04-13T05:36:08Z

        foreach ($this->getGenerator() as $val) {
            if (\is_array($val)) {
-                $result[] = (new static($val))->reduce_dimension($unique)->toArray();
+                $result[] = (new static($val))->reduce_dimension($unique)->toArray(); // @phpstan-ignore new.static


Using the factory method static::create($val) here would remove the need for this inline suppression and maintain consistency with how the class is intended to be instantiated.

$result[] = static::create($val)->reduce_dimension($unique)->toArray();

gemini-code-assist · 2026-04-13T05:36:08Z

        $result = $result === [] ? [] : \array_merge(...$result);

-        $resultArrayy = new static($result);
+        $resultArrayy = new static($result); // @phpstan-ignore new.static


Using static::create($result) here avoids the new static warning and removes the need for an inline ignore.

$resultArrayy = static::create($result);

Copilot

Pull request overview

This PR tightens PHPStan suppression handling by removing broad ignoreErrors patterns, fixing previously-suppressed callable issues in code, and making iterator generics explicit across collections and models.

Changes:

Enable reportUnmatchedIgnoredErrors and replace broad/regex ignores with narrower rules (including identifier-based ignores).
Replace call_user_func* usage with direct invocation to satisfy PHPStan callable analysis.
Add/expand ArrayyIterator<...> generic annotations and move remaining suppressions closer to the affected lines.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`phpstan.neon`	Enables unmatched-ignore reporting; removes broad ignores; switches to identifier-based ignore for missing return types in tests.
`src/StaticArrayy.php`	Replaces `call_user_func_array` with dynamic method invocation on `Arrayy`.
`src/ArrayyIterator.php`	Replaces `call_user_func` with direct static call via class-string for iterator element wrapping.
`src/ArrayyRewindableExtendedGenerator.php`	Same callable fix as iterator for generator-backed iteration.
`src/Arrayy.php`	Adds iterator generic annotations and introduces several inline suppressions for `new static` and assignment-type findings.
`src/Collection/Collection.php`	Updates iterator generic phpdoc and adds inline suppression on `new static`.
`src/Collection/AbstractCollection.php`	Updates iterator generic phpdoc and adds inline suppression on `new static`.
`src/Collection/CollectionInterface.php`	Refines `create()` iteratorClass generic annotation.
`src/TypeCheck/TypeCheckArray.php`	Refines iteratorClass generic annotation.
`src/Type/InstancesCollection.php`	Refines nullable iteratorClass generic annotation.
`src/Type/InstanceCollection.php`	Refines nullable iteratorClass generic annotation.
`src/Type/DetectFirstValueTypeCollection.php`	Refines iteratorClass generic annotation.
`tests/ModelA.php`	Refines iteratorClass generic annotation for test model.
`tests/StaticArrayyTest.php`	Replaces file-wide static-method ignore with line-local suppressions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-13T05:36:17Z

        /** @noinspection PhpUndefinedMethodInspection */
        /** @noinspection PhpUnusedLocalVariableInspection */
-        $result = A::invalidMethod('foo');
+        $result = A::invalidMethod('foo'); // @phpstan-ignore staticMethod.notFound


The inline suppression marker here uses @phpstan-ignore staticMethod.notFound, but elsewhere in the repo suppressions are written as @phpstan-ignore-line / @phpstan-ignore-next-line (e.g. tests/PHPStan/AnalyseTest.php). To avoid the suppression being ignored by PHPStan, switch these to the supported ...-line/...-next-line form (and apply the same change to the other occurrences in this test).

Copilot · 2026-04-13T05:36:17Z

                \is_array($this->array[$key])
            ) {
-                $this->array[$key][] = $value;
+                $this->array[$key][] = $value; // @phpstan-ignore assign.propertyType


This suppression comment uses // @phpstan-ignore assign.propertyType. In this codebase, PHPStan inline ignores are typically written as @phpstan-ignore-line / @phpstan-ignore-next-line; using a non-standard tag risks the ignore being ineffective and PHPStan still reporting the error. Please use the supported ...-line/...-next-line form (and update the other new @phpstan-ignore ... occurrences in this file similarly).

Suggested change

$this->array[$key][] = $value; // @phpstan-ignore assign.propertyType

$this->array[$key][] = $value; // @phpstan-ignore-line

Copilot · 2026-04-13T05:36:17Z

        bool $checkPropertiesInConstructor = true
    ) {
-        return new static(
+        return new static( // @phpstan-ignore new.static


This new static suppression is written as // @phpstan-ignore new.static. The repo generally uses @phpstan-ignore-line / @phpstan-ignore-next-line for inline PHPStan suppression; if this tag isn’t recognized, PHPStan will still emit the new.static error. Please switch to the supported ignore form here and for the other new static suppressions introduced in this PR.

Suggested change

return new static( // @phpstan-ignore new.static

return new static( // @phpstan-ignore-line

Copilot · 2026-04-13T05:36:18Z

        $type = self::convertIntoTypeCheckArray($type);

-        return new static(
+        return new static( // @phpstan-ignore new.static


The inline suppression here uses // @phpstan-ignore new.static. To stay consistent with existing PHPStan suppressions in the repo (and ensure PHPStan actually honors it), prefer @phpstan-ignore-line / @phpstan-ignore-next-line instead of a bare @phpstan-ignore tag.

Suggested change

return new static( // @phpstan-ignore new.static

return new static( // @phpstan-ignore-line

Copilot · 2026-04-13T05:36:18Z

        bool $checkPropertiesInConstructor = true
    ) {
-        return new static(
+        return new static( // @phpstan-ignore new.static


The suppression marker on this new static call is // @phpstan-ignore new.static. Elsewhere in the repository inline suppressions use @phpstan-ignore-line / @phpstan-ignore-next-line; please use that form here to avoid the ignore being treated as a plain comment by PHPStan.

Suggested change

return new static( // @phpstan-ignore new.static

// @phpstan-ignore-next-line

return new static(

voku · 2026-04-13T05:42:08Z

@copilot apply changes based on the comments in this thread + here is the feedback from another llm, so cross check both and add tests and phpstan runs for validation because maybe the LLM was wrong with the feedback : gemini-code-assist bot
left a comment
Code Review
This pull request improves PHPStan static analysis by enabling unmatched error reporting, adding generic type hints to iterator classes, and replacing call_user_func with direct method calls. Feedback suggests using the @phpstan-consistent-constructor annotation and the static::create() factory method to eliminate several newly added inline suppressions and improve code consistency.

src/Arrayy.php
bool $checkPropertiesInConstructor = true
) {
return new static(
return new static( // @phpstan-ignore new.static
@gemini-code-assist
gemini-code-assist bot
4 minutes ago
medium

Instead of multiple inline @phpstan-ignore new.static suppressions, consider adding the @phpstan-consistent-constructor annotation to the Arrayy class definition. This informs PHPStan that all subclasses are expected to maintain a compatible constructor signature, which is a cleaner way to resolve this warning globally for the entire class hierarchy.

@voku Reply...
src/Arrayy.php
{
// init
$arrayy = new static();
$arrayy = new static(); // @phpstan-ignore new.static
@gemini-code-assist
gemini-code-assist bot
4 minutes ago
medium

You can avoid this inline suppression by using the existing factory method static::create(). This also ensures that any instantiation logic within create() is consistently applied.

    $arrayy = static::create();

@voku Reply...
src/Arrayy.php
foreach ($this->getGenerator() as $val) {
if (\is_array($val)) {
$result[] = (new static($val))->reduce_dimension($unique)->toArray();
$result[] = (new static($val))->reduce_dimension($unique)->toArray(); // @phpstan-ignore new.static
@gemini-code-assist
gemini-code-assist bot
4 minutes ago
medium

Using the factory method static::create($val) here would remove the need for this inline suppression and maintain consistency with how the class is intended to be instantiated.

            $result[] = static::create($val)->reduce_dimension($unique)->toArray();

@voku Reply...
src/Arrayy.php
$result = $result === [] ? [] : \array_merge(...$result);

    $resultArrayy = new static($result);
    $resultArrayy = new static($result); // @phpstan-ignore new.static

@gemini-code-assist
gemini-code-assist bot
4 minutes ago
medium

Using static::create($result) here avoids the new static warning and removes the need for an inline ignore.

    $resultArrayy = static::create($result);

Agent-Logs-Url: https://github.com/voku/Arrayy/sessions/03d2ec65-21a1-46b0-a32a-cf89ab30fc03 Co-authored-by: voku <264695+voku@users.noreply.github.com>

Copilot · 2026-04-13T05:46:08Z

@copilot apply changes based on the comments in this thread + here is the feedback from another llm, so cross check both and add...

Addressed in cbaf547. I switched the new inline suppressions to @phpstan-ignore-line / @phpstan-ignore-next-line, replaced the avoidable new static usages in Arrayy with static::create(), and re-ran validation. Targeted PHPUnit passed for StaticArrayyTest and the ArrayyTest create/reduce cases; full PHPUnit still shows the same pre-existing 2 testAverage errors and 1 testChangeKeyCase failure, and full PHPStan remains at 394 existing issues. No UI changes in this PR.

Agent-Logs-Url: https://github.com/voku/Arrayy/sessions/6f97f935-8d10-418f-adcd-0b45e745ea89 Co-authored-by: voku <264695+voku@users.noreply.github.com>

sonarqubecloud · 2026-04-13T06:09:18Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copilot AI and others added 2 commits April 13, 2026 02:37

Refine phpstan ignore handling

945202c

Agent-Logs-Url: https://github.com/voku/Arrayy/sessions/a2861208-06a3-4d4d-b396-8a01a9ea1c6c Co-authored-by: voku <264695+voku@users.noreply.github.com>

Finalize phpstan ignore cleanup

9f6c38c

Agent-Logs-Url: https://github.com/voku/Arrayy/sessions/a2861208-06a3-4d4d-b396-8a01a9ea1c6c Co-authored-by: voku <264695+voku@users.noreply.github.com>

Copilot AI assigned Copilot and voku Apr 13, 2026

Copilot created this pull request from a session on behalf of voku April 13, 2026 05:26 View session

voku marked this pull request as ready for review April 13, 2026 05:32

voku requested a review from Copilot April 13, 2026 05:32

Copilot started reviewing on behalf of voku April 13, 2026 05:33 View session

gemini-code-assist bot reviewed Apr 13, 2026

View reviewed changes

Copilot AI reviewed Apr 13, 2026

View reviewed changes

Copilot started work on behalf of voku April 13, 2026 05:42 View session

Apply review follow-up phpstan cleanup

cbaf547

Agent-Logs-Url: https://github.com/voku/Arrayy/sessions/03d2ec65-21a1-46b0-a32a-cf89ab30fc03 Co-authored-by: voku <264695+voku@users.noreply.github.com>

Copilot finished work on behalf of voku April 13, 2026 05:47

Copilot AI requested a review from voku April 13, 2026 05:47

Copilot started work on behalf of voku April 13, 2026 06:04 View session

Use PHPStan v2 inline identifiers

c271dd1

Agent-Logs-Url: https://github.com/voku/Arrayy/sessions/6f97f935-8d10-418f-adcd-0b45e745ea89 Co-authored-by: voku <264695+voku@users.noreply.github.com>

Copilot finished work on behalf of voku April 13, 2026 06:10

voku merged commit 5ecd471 into master Apr 13, 2026
13 of 15 checks passed

	$this->array[$key][] = $value; // @phpstan-ignore assign.propertyType
	$this->array[$key][] = $value; // @phpstan-ignore-line

	return new static( // @phpstan-ignore new.static
	return new static( // @phpstan-ignore-line

	return new static( // @phpstan-ignore new.static
	// @phpstan-ignore-next-line
	return new static(

Uh oh!

Conversation

Copilot AI commented Apr 13, 2026 • edited by voku Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Apr 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

voku commented Apr 13, 2026

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

Uh oh!

voku commented Apr 13, 2026

Uh oh!

Copilot AI commented Apr 13, 2026

Uh oh!

sonarqubecloud bot commented Apr 13, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 13, 2026 •

edited by voku

Loading

coveralls commented Apr 13, 2026 •

edited

Loading